Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ar label code #250

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Remove ar label code #250

merged 1 commit into from
Jul 30, 2024

Conversation

rishabh-ranjan
Copy link
Collaborator

Because 1. will have to fix caching to support properly and 2. it doesn't work on rel-f1, rel-event and rel-avito with error "Timestamps are not equally spaced...".

Looks better to remove from public facing code.

Copy link
Collaborator

@joshr17 joshr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabh-ranjan rishabh-ranjan merged commit 2495e12 into main Jul 30, 2024
4 checks passed
@rishabh-ranjan rishabh-ranjan deleted the rr-remove-ar branch July 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants