feat: list storage candidates #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-plugin-gcs into list_candidates
johanneskoester
requested changes
Apr 26, 2024
|
Mhm, now it fails. Is that my fault? If so, sorry if I broke something. |
…ge-plugin-gcs into list_candidates
Ah sorry I had used a character count for gcs:// and bucket name to obtain the list_blobs prefix. |
johanneskoester
approved these changes
Aug 19, 2024
johanneskoester
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.0...v1.1.0) (2024-08-19) ### Features * list storage candidates ([#30](#30)) ([c7ba28e](c7ba28e)) ### Bug Fixes * fixing the directory() issue due to uploading the local_prefix instead of GCS prefix. ([#41](#41)) ([27c80dc](27c80dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry accidentally closed the previous pull request. Did the suggested formatting changes. Still trying to figure out testing.