Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow kubernetes versions 28 and 29 #10

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

musicinmybrain
Copy link
Contributor

I am not able to test this plugin myself since I don’t have the necessary Kubernetes environment, but the release notes don’t show anything that would obviously cause problems.

https://github.com/kubernetes-client/python/blob/v29.0.0/CHANGELOG.md

In Fedora Linux, we have python-kubernetes version 29.0.0, which is the current version, so we need to use that rather than pinning an older version.

In general, https://pypi.org/project/kubernetes/ bumps the major version number frequently but rarely seems to introduce large breaking changes. It may be less troublesome overall to avoid setting an upper bound on the version of this dependency at all.

@johanneskoester johanneskoester changed the title Allow kubernetes versions 28 and 29 fix: Allow kubernetes versions 28 and 29 Feb 5, 2024
@johanneskoester
Copy link
Contributor

Sure, if that works I have no objections. Ideally we can spawn a matrix here in github actions that tests multiple different versions of the kubernetes package. Could you make such a change in this PR?

@musicinmybrain
Copy link
Contributor Author

(Hmm, it looks like the CI tests didn’t pass, but I’m not sure how to debug them.)

Sure, if that works I have no objections. Ideally we can spawn a matrix here in github actions that tests multiple different versions of the kubernetes package. Could you make such a change in this PR?

I could, but I don’t have much experience with configuring GitHub’s CI and I can’t run the tests locally, which makes this a bit of an uphill battle. Is there an example of such a testing matrix in one of the other snakemake plugins that I could use as a starting point?

@johanneskoester
Copy link
Contributor

Hitting this issue in the tests: boto/botocore#3111

@johanneskoester johanneskoester merged commit 47a5f37 into snakemake:main Mar 12, 2024
4 checks passed
johanneskoester pushed a commit that referenced this pull request Mar 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.5](v0.1.4...v0.1.5)
(2024-03-12)


### Bug Fixes

* Allow kubernetes versions 28 and 29
([#10](#10))
([47a5f37](47a5f37))
* update snakemake-interface-executor-plugins requirement from ^8.0.2 to
>=9.0.0,<10.0.0
([#12](#12))
([861c44f](861c44f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants