Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): update phpstan/phpstan requirement from 1.10.18 to 1.10.33 #1679

Merged
merged 3 commits into from
Sep 9, 2023
Merged

build(deps-dev): update phpstan/phpstan requirement from 1.10.18 to 1.10.33 #1679

merged 3 commits into from
Sep 9, 2023

Commits on Sep 9, 2023

  1. build(deps-dev): update phpstan/phpstan requirement 

    Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.18...1.10.33)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    4049c50 View commit details
    Browse the repository at this point in the history

  2. SmrAlliance: disallow alliance ID of 0 

    Previously, we would allow creating an `SmrAlliance` instance when the
input `$allianceID` was 0. This was problematic because most of the
class attributes would be unset, and most methods would be unusable.

Now, we will raise an AllianceNotFoundError if the ID is 0, and we
remove the `isNone` method. This will ensure that all instances of the
class are valid and can be used without restriction. We replace the
existing `isNone` calls with checks if the alliance ID is 0.
    @hemberger
    hemberger committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    6e1fe8c View commit details
    Browse the repository at this point in the history

  3. Improve TraderCombatResult type 

    Always initialize the `TotalDamagePerTargetPlayer` field of the
`TraderCombatResult` array type. This fixes a PHPStan warning.
    @hemberger
    hemberger committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    0d7e33e View commit details
    Browse the repository at this point in the history