TunTapInterface: do not automatically enable medium-ethernet feature when phy-tuntap_interface is enabled #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when phy-tuntap_interface is enabled `TunTapInterface` can work in TUN L3 mode which does not require `medium-ethernet` feature. `TunTapInterface` already mostly respects `medium-ethernet` feature flag and enables relevant TAP L2 functionality only when `medium-ethernet` is enabled. However, in Cargo.toml features configuration automatically enables `medium-ethernet` feature when `phy-tuntap_interface` feature is enabled, making it impossible to opt-out of Ether support when using TUN L3 interfaces. In this change I'm updating Cargo.toml to not enable `medium-ethernet` feature when `phy-tuntap_interface` feature is enabled. With this change `phy-tuntap_interface` supports TUN L3 interfaces only by default. Users who want to use TAP L2 interfaces have to enable the support by enabling `medium-ethernet` in addition to `phy-tuntap_interface` I confirmed that build passes in configuration where `phy-tuntap_interface` is enabled but `medium-ethernet` is not: ``` cargo build --no-default-features --features medium-ip,proto-ipv4,socket-tcp,phy-tuntap_interface ```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 81.17% 81.17%
=======================================
Files 81 81
Lines 28956 28956
=======================================
Hits 23505 23505
Misses 5451 5451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TunTapInterfacecan work in TUN L3 mode which does not requiremedium-ethernetfeature.TunTapInterfacealready mostly respectsmedium-ethernetfeature flag and enables relevant TAP L2 functionality only whenmedium-ethernetis enabled.However, in Cargo.toml features configuration automatically enables
medium-ethernetfeature whenphy-tuntap_interfacefeature is enabled, making it impossible to opt-out of Ether support when using TUN L3 interfaces.In this change I'm updating Cargo.toml to not enable
medium-ethernetfeature whenphy-tuntap_interfacefeature is enabled. With this changephy-tuntap_interfacesupports TUN L3 interfaces only by default. Users who want to use TAP L2 interfaces have to enable the support by enablingmedium-ethernetin addition tophy-tuntap_interfaceI confirmed that build passes in configuration where
phy-tuntap_interfaceis enabled butmedium-ethernetis not: