Throw errors from Neovim

smolck · Nov 25, 2020 · 4682017 · 4682017
1 parent 9f8e59f
commit 4682017
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/src/neovim.dart b/lib/src/neovim.dart
@@ -31,6 +31,10 @@ class Nvim {
         mpack.deserialize(data, extDecoder: ExtTypeDecoder());
     switch (deserialized[0]) {
       case RESPONSE:
+        if (deserialized[2] != null) {
+          // Throw any errors from Neovim.
+          throw deserialized[2][1];
+        }
         // TODO(smolck): Verify `deserialized[1]` is the id.
         nvim._waiting[deserialized[1]].complete(deserialized[3]);
         break;

diff --git a/test/neovim_test.dart b/test/neovim_test.dart
@@ -21,10 +21,6 @@ void main() async {
 
   test('windows work', () async {
     var winBuf = await nvim.createBuf(true, false);
-    // TODO(smolck): Neovim errors for if you, say, don't use the required
-    // `relative` or `external` parameters, are completely silent. Should
-    // probably use exceptions for when Neovim returns the wrong thing or
-    // something.
     var win = await nvim.openWin(winBuf, true, {
       'relative': 'editor',
       'width': 12,