Merge pull request pnp#1964 from patrick-rodgers/version-3

test updates, updating todos
smolattack · Dec 9, 2021 · f94e9a5 · f94e9a5
2 parents 882329c + b6fa23d
commit f94e9a5
Show file tree

Hide file tree

Showing 46 changed files with 10,569 additions and 2,204 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/graph/calendars.ts b/test/graph/calendars.ts
@@ -20,7 +20,6 @@ describe("Calendar", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/contacts.ts b/test/graph/contacts.ts
@@ -21,7 +21,6 @@ describe("Contacts", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/directoryobjects.ts b/test/graph/directoryobjects.ts
@@ -21,7 +21,6 @@ describe("Directory Objects", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/groups.ts b/test/graph/groups.ts
@@ -14,7 +14,6 @@ describe("Groups", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/outlook.ts b/test/graph/outlook.ts
@@ -19,7 +19,6 @@ describe("Outlook", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/planner.ts b/test/graph/planner.ts
@@ -17,7 +17,6 @@ describe.skip("Planner", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/graph/teams.ts b/test/graph/teams.ts
@@ -18,7 +18,6 @@ describe("Teams", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _graphfi = getGraph();

diff --git a/test/nodejs/sp-extensions.ts b/test/nodejs/sp-extensions.ts
@@ -19,7 +19,6 @@ describe("NodeJS: sp-extensions", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/queryable/behaviors.ts b/test/queryable/behaviors.ts
@@ -24,7 +24,6 @@ describe("Behaviors", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         try {
@@ -56,7 +55,6 @@ describe("Behaviors", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         try {
@@ -93,7 +91,6 @@ describe("Behaviors", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         try {

diff --git a/test/sp/alias.ts b/test/sp/alias.ts
@@ -19,7 +19,6 @@ describe("Alias Parameters", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/appcatalog.ts b/test/sp/appcatalog.ts
@@ -26,7 +26,6 @@ describe("AppCatalog", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/attachments.ts b/test/sp/attachments.ts
@@ -17,7 +17,6 @@ describe("Attachments", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/batch.ts b/test/sp/batch.ts
@@ -21,7 +21,6 @@ describe("Batching", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/clientside-pages.ts b/test/sp/clientside-pages.ts
@@ -18,7 +18,6 @@ describe("Clientside Pages", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/column-defaults.ts b/test/sp/column-defaults.ts
@@ -23,7 +23,6 @@ describe("DefaultColumnValues", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/comments.ts b/test/sp/comments.ts
@@ -20,7 +20,6 @@ describe("Comments", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/content-types.ts b/test/sp/content-types.ts
@@ -12,7 +12,6 @@ describe("Content Types", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -43,7 +42,6 @@ describe("Content Type", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/features.ts b/test/sp/features.ts
@@ -13,7 +13,6 @@ describe("Features", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/fields.ts b/test/sp/fields.ts
@@ -29,7 +29,6 @@ describe("Fields", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/files.ts b/test/sp/files.ts
@@ -28,7 +28,6 @@ describe("Files", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -140,7 +139,6 @@ describe("File", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/folders.ts b/test/sp/folders.ts
@@ -19,7 +19,6 @@ describe("Folders", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -43,7 +42,6 @@ describe("Folder", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/forms.ts b/test/sp/forms.ts
@@ -14,7 +14,6 @@ describe("Forms", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/hubsites.ts b/test/sp/hubsites.ts
@@ -13,7 +13,6 @@ describe("Hubsites", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         // Must use root site

diff --git a/test/sp/items.ts b/test/sp/items.ts
@@ -18,7 +18,6 @@ describe("Items", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/lists.ts b/test/sp/lists.ts
@@ -22,7 +22,6 @@ describe("Lists", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -98,7 +97,6 @@ describe("List", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/navigation.ts b/test/sp/navigation.ts
@@ -14,7 +14,6 @@ describe("Navigation Service", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -77,7 +76,6 @@ describe("navigation", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/regional-settings.ts b/test/sp/regional-settings.ts
@@ -12,7 +12,6 @@ describe("Regional Settings", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/related-items.ts b/test/sp/related-items.ts
@@ -23,7 +23,6 @@ describe("Related Items", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/search.ts b/test/sp/search.ts
@@ -13,7 +13,6 @@ describe.skip("Search", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/security.ts b/test/sp/security.ts
@@ -20,7 +20,6 @@ describe("Security", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/sharing.ts b/test/sp/sharing.ts
@@ -26,7 +26,6 @@ describe("Sharing", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/site-designs.ts b/test/sp/site-designs.ts
@@ -21,7 +21,6 @@ describe.skip("SiteDesigns", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/site-groups.ts b/test/sp/site-groups.ts
@@ -17,7 +17,6 @@ describe("SiteGroups", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -96,7 +95,6 @@ describe("SiteGroups", function () {
             }
         });
         return expect(p).to.be.eventually.fulfilled;
-        return true;
     });
 
     it("setUserAsOwner()", async function () {

diff --git a/test/sp/site-scripts.ts b/test/sp/site-scripts.ts
@@ -28,7 +28,6 @@ describe("SiteScripts", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         const _spfi = getSP();

diff --git a/test/sp/site-users.ts b/test/sp/site-users.ts
@@ -27,7 +27,6 @@ describe("Site Users", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
     });
 

diff --git a/test/sp/sites.ts b/test/sp/sites.ts
@@ -16,7 +16,6 @@ describe("Sites", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
@@ -81,7 +80,6 @@ describe("createModern Team & Comm Sites", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/sputilities.ts b/test/sp/sputilities.ts
@@ -17,7 +17,6 @@ describe.skip("SPUtilities", function () {
 
         if (!testSettings.enableWebTests) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();

diff --git a/test/sp/subscriptions.ts b/test/sp/subscriptions.ts
@@ -18,7 +18,6 @@ describe("Subscriptions", function () {
 
         if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings?.sp?.notificationUrl)) {
             this.skip();
-            return;
         }
 
         _spfi = getSP();
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,6 @@ describe("Calendar", function () { @@
             if (!testSettings.enableWebTests || stringIsNullOrEmpty(testSettings.testUser)) {
                 this.skip();
-                return;
             }
             _graphfi = getGraph();
@@ Expand Down @@