Skip to content

Commit

Permalink
update to contributor file
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-rodgers committed Dec 20, 2019
1 parent 2977bda commit 539a654
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# Contributing Guidance
## Contributing Guidance - v2

* Target your pull requests to the **dev-v2** branch
* Target your pull requests to the **version-2** branch
* Add/Update any docs articles related to your changes
* Include a test for any new functionality and ensure all existing tests are passing by running `npm test`
* If you are fixing a but, include a test that would have caught the bug you are fixing
* If you are fixing a bug, include a test that would have caught the bug you are fixing
* Ensure tslint checks pass by typing `npm run lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)

> If you need to target a PR for version 1, please target the "version-1" branch

## Contributing Guidance - v1

* Target your pull requests to the **version-1** branch
* Ensure tslint checks pass by typing `gulp lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)

0 comments on commit 539a654

Please sign in to comment.