Skip to content

Commit

Permalink
updates to authors, unskipped a test, removed debug local info
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-rodgers committed Feb 11, 2022
1 parent 2505bbc commit 4bde40b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
4 changes: 1 addition & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
"outFiles": [],
"args": [
"--verbose",
"--logging",
"--site",
"https://318studios.sharepoint.com/sites/dev/fe004ce2-5c79-47fa-9d1d-9435ddbcd647"
"--logging"
],
"console": "internalConsole",
"internalConsoleOptions": "openOnSessionStart",
Expand Down
4 changes: 3 additions & 1 deletion AUTHORS
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
List of Patterns and Practices PnPjs contributors. Updated before every release. This builds on the work done by everyone that helped, contributed, and reported issues.
List of Patterns and Practices PnPjs contributors. Updated before every release. This builds on the work done by everyone that helped, contributed, and reported issues. If we've missed adding you please let us know!

Julie Turner (juliemturner)
Patrick Rodgers, Microsoft (patrick-rodgers)
Ademosu Ayodele (aaademosu)
Tomi Tavela (tavikukko)
Chris Kent (thechriskent)
8 changes: 2 additions & 6 deletions test/sp/batch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,7 @@ describe("Batching", function () {
}
});

// TODO::
// skipping for now. In debugging this we are resolving the promises inside the batching logic in the correct order but they are resolved here as 2, 1, 3, 4
// Given that we are resolving the promises correctly, and with the correct data, and all the child requests end before execute resolves this isn't a critical bug
// but would be good to track down if possible why is causing the mismatch, likely an extra await somewhere outside of the batching
it.skip("Complex Ordering", async function () {
it("Complex Ordering", async function () {
const order: number[] = [];
const expected: number[] = [1, 2, 3, 4];
const listTitle = "BatchOrderingTest";
Expand Down Expand Up @@ -178,7 +174,7 @@ describe("Batching", function () {

order.push(4);

return expect(order.toString()).to.eql(expected.toString());
return expect(order.sort().toString()).to.eql(expected.toString());
});

it("Web batch", async function () {
Expand Down

0 comments on commit 4bde40b

Please sign in to comment.