Fix new nightly Clippy warnings #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suppress warning from the cfg(loom) directive by having it emit "rustc-check-cfg" in build.rs - Remove usage of legacy "std::usize" module. - Ignore "clippy::multiple_bound_locations". We use multiple bounds as a workaround for an issue in pin-project-lite where only one bound can be assigned per location. The phrasing of pin-project-lite's README implies that this issue is WONTFIX. To quote: > This library does not tackle as expansive of a range of use cases as > pin-project does. If your use case is not already covered, please use > pin-project. Signed-off-by: John Nunley <[email protected]>
|
MIRI failure is tracked in #133 |
taiki-e
reviewed
May 19, 2024
| //! Without this, the compiler complains about the unspecified "loom" flag. | ||
|
|
||
| fn main() { | ||
| println!("cargo:rustc-check-cfg=cfg(loom)"); |
There was a problem hiding this comment.
I would like to use rust-lang/cargo#13913 's config option instead of adding build script.
taiki-e
reviewed
May 19, 2024
| @@ -68,6 +68,7 @@ | |||
| //! [`portable-atomic`]: https://crates.io/crates/portable-atomic | |||
|
|
|||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
| #![allow(clippy::multiple_bound_locations)] // This is a WONTFIX issue with pin-project-lite | |||
There was a problem hiding this comment.
If this lint is triggered for code generated by external macros, it is definitely clippy bug.
There was a problem hiding this comment.
Ok, I found rust-lang/rust-clippy#12552.
There was a problem hiding this comment.
Oh, looking at your PR description, this lint may also need to be allowed on the pin-project-lite side, but it's not clear which one is actually causing a warning here.
notgull
added a commit
that referenced
this pull request
May 19, 2024
#135 (comment) Signed-off-by: John Nunley <[email protected]>
notgull
added a commit
that referenced
this pull request
May 20, 2024
#135 (comment) Signed-off-by: John Nunley <[email protected]>
notgull
added a commit
that referenced
this pull request
May 20, 2024
#135 (comment) Signed-off-by: John Nunley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"rustc-check-cfg" in build.rs
workaround for an issue in pin-project-lite where only one bound can be
assigned per location. The phrasing of pin-project-lite's README implies that
this issue is WONTFIX. To quote: