Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nom v8 #2103

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update to nom v8 #2103

merged 1 commit into from
Mar 11, 2025

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 11, 2025

While the diff is quite big, all the changes were very straight-forward:

  • Removing one generic parameter from all_consuming.
  • Use the Parser trait instead of calling closures.
  • Return impl Parser instead of impl FnMut.
  • Make some error types explicit.
  • Remove calls to nom::sequence::tuple() as they are no longer needed.

Everything seems to work, and first try.

@tomaka tomaka added this pull request to the merge queue Mar 11, 2025
Merged via the queue into smol-dot:main with commit c9d02b4 Mar 11, 2025
22 checks passed
@tomaka tomaka deleted the nom-8 branch March 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant