Skip to content

Commit

Permalink
tweak contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
swyxio committed Jul 31, 2023
1 parent 83547d8 commit 06ddf43
Showing 1 changed file with 39 additions and 10 deletions.
49 changes: 39 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ this is a FOSS effort and will never be commercialized (no tracking, will not be

- **a PR to make the 3 panels customizable to different URLs and input targets!**
- a "Windows maintainer" to handle Windows user needs and beta test every release to make sure we didn't break something for them
- Design
- i need a new set of icons for the images
- better styling for the window? maybe normalize the bard window to the openai dimensions?

## Install and Run from Source

Expand Down Expand Up @@ -49,24 +46,56 @@ Apple is a piece of sht.

copy `.env.example` to `.env` and follow https://www.electronforge.io/guides/code-signing/code-signing-macos (we tried option 1, but eventually ended up with option 2 as you see below)

then you have to generate a bunch of shit
then you have to generate a bunch of stuff
https://medium.com/ascentic-technology/getting-an-electron-app-ready-for-macos-distribution-2941fce27450

follow this

he sucks at documenting but at least we got it notarized

bitch

```bash
$ spctl -a -vvv -t install smolmenubar.app
smolmenubar.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Shawn Wang (7SVH735GV7)
```

all of this has now been packaged into a script called `npm run buildAndSign`. Note that for now, this script ONLY runs on swyx's macbook air inside the terminal (and somehow NOT in vsocde, i dont know why). If you are experienced with electron signing and notarizing, please help us make this work for all contributors!

```bash
npm run buildAndSign
> [email protected] buildAndSign
> NODE_ENV=sign npm run make
> [email protected] make
> electron-forge make --arch arm64,x64
✔ Checking your system
✔ Loading configuration
✔ Resolving make targets
› Making for the following targets: dmg
✔ Loading configuration
✔ Resolving make targets
› Making for the following targets: dmg
✔ Running package command
✔ Preparing to package application
✔ Running packaging hooks
✔ Running generateAssets hook
✔ Running prePackage hook
✔ Packaging application
✔ Packaging for arm64 on darwin [2m15s]
✔ Packaging for x64 on darwin [2m27s]
✔ Running postPackage hook
✔ Running preMake hook
✔ Making distributables
✔ Making a dmg distributable for darwin/arm64 [7s]
✔ Making a dmg distributable for darwin/x64 [8s]
✔ Running postMake hook
› Artifacts available at: /Users/swyx/Documents/Work/smol-menubar/out/make
```

## publishing to app store

> NOTE: we havent actually gotten this working yet, i just straight up gave up

the below from https://developer.apple.com/help/app-store-connect/manage-builds/upload-builds is something like what we want

```bash
Expand Down

0 comments on commit 06ddf43

Please sign in to comment.