minor fixes in doc and examples

smndev · Sep 3, 2021 · f3c7140 · f3c7140
1 parent c321cd3
commit f3c7140
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 8 deletions.
diff --git a/BUILDING.md b/BUILDING.md
@@ -13,7 +13,6 @@ and then edit the keys defines is this file as described in the following table.
 
 | Key                     | Description |
 | ----------------------- | ----------- |
-| ``DEBUG``               | If set to ``true`` the code will not be optimized |
 | ``ALCHEMY_API_KEY``     | Tke [Alchemy](https://docs.alchemy.com/alchemy/introduction/getting-started) API key        |
 | ``RINKEBY_PRIVATE_KEY`` | The Rinkeby private key used for deployng the contract  |
 | ``MAINNET_PRIVATE_KEY`` | The main net private key used for deployng the contract |

diff --git a/contracts/NFT.sol b/contracts/NFT.sol
@@ -56,4 +56,16 @@ contract NFT is ERC721, Ownable {
         }
     }
 
+    /**
+    * @dev Withdraw ETH from this contract (Callable by owner)
+    */
+    function withdraw() onlyOwner() public returns (bool) {
+        uint balance = address(this).balance;
+        (bool success, ) = _msgSender().call{value:balance}("");
+        // no need to call throw here or handle double entry attack
+        // since only the owner is withdrawing all the balance
+        return success;
+    }
+
+
 }
diff --git a/contracts/UC1.sol b/contracts/UC1.sol
@@ -37,12 +37,12 @@ contract UC1 is ERC721, Ownable {
     // Mapping if certain name string has already been reserved
     mapping (string => bool) private _nameReserved;
 
-    // the NCT contract pointer
+    // the NCT contract pointder
     INCT private _nct;
 
 
     // Events
-    event NameChange (uint256 indexed maskIndex, string newName);
+    event NameChange (uint256 indexed tokenIdx, string newName);
 
 
     /**
@@ -169,4 +169,16 @@ contract UC1 is ERC721, Ownable {
         }
         return string(bLower);
     }
+
+    /**
+    * @dev Withdraw ETH from this contract (Callable by owner)
+    */
+    function withdraw() onlyOwner() public returns (bool) {
+        uint balance = address(this).balance;
+        (bool success, ) = _msgSender().call{value:balance}("");
+        // no need to call throw here or handle double entry attack
+        // since only the owner is withdrawing all the balance
+        return success;
+    }
+
 }
diff --git a/contracts/UC2.sol b/contracts/UC2.sol
@@ -34,7 +34,7 @@ contract UC2 is Ownable {
     INCT    private _nct;
 
     // Events
-    event NameChange (uint256 indexed maskIndex, string newName);
+    event NameChange (uint256 indexed tokenIdx, string newName);
 
 
     /**

diff --git a/env.example b/env.example
@@ -1,4 +1,3 @@
-DEBUG=false
 ALCHEMY_API_KEY=KEY
 RINKEBY_PRIVATE_KEY=YOUR_RINKEBY_PRIVATE_KEY
 MAINNET_PRIVATE_KEY=YOUR_MAIN_NET_PRIVATE_KEY

diff --git a/hardhat.config.js b/hardhat.config.js
@@ -10,7 +10,7 @@ module.exports = {
     solidity: {
         compilers: [{
             version: '0.8.0', settings: {
-                optimizer: {enabled: !env.DEBUG},
+                optimizer: {enabled: true},
             },
         },]
     },

diff --git a/package.json b/package.json
@@ -1,13 +1,13 @@
 {
   "name": "nctproject",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "How to integrate Name Changing Token (NCT) to a new or existing NFT project",
   "main": "index.js",
   "scripts": {
     "test": "npx hardhat test",
     "compile": "npx hardhat compile",
     "deploy-rinkeby": "npx hardhat run scripts/deploy-testing.js --network rinkeby",
-    "deploy-mainnet": "DEBUG=false npx hardhat run scripts/deploy-mainnet.js --network mainnet"
+    "deploy-mainnet": "npx hardhat run scripts/deploy-mainnet.js --network mainnet"
   },
   "keywords": [
     "NCT",