Update IDL serializer to write metadata to a separate file #2464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
SmithyIdlModelSerializer
to write all metadata to a separatemetadata.smithy
file rather than duplicating the metadata within each generated file.Generating a separate smithy metadata files avoids potentially duplicating array data.
Detail on issue
For example the following files
and
Were previously re-written as:
and
This created a problem where, when using these models in a new model, the resulting metadata for
hello
would be an array containing
[1,2,1,2]
effectively duplicating all array data N times (N being number of smithy files generated).Updated behavior
With this change the following files would now be written for the above example:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.