Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator for xmlFlattened + xmlName #2439

Merged

Commits on Nov 1, 2024

  1. Add validator for xmlFlattened + xmlName

    Adds a validator for the xmlFlattened trait that checks if the member's
    target is a list that has a member with xmlName, and that xmlName
    doesn't match the name of the xmlFlattened member. xmlFlattened causes
    the xmlName of the list member to be ignored. This is called out in our
    docs:
    https://smithy.io/2.0/spec/protocol-traits.html#flattened-list-serialization,
    but we were missing a validator for it. It is a warning because you might
    mean to do this, i.e. if the list is used in multiple places.
    
    I also added some suppressions to our protocol tests that are testing
    the behavior for models that would trip up this validator.
    milesziemer committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    81b6261 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Address feedback

    milesziemer committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fbd772b View commit details
    Browse the repository at this point in the history