-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Consider an empty string header value to be present #832
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba039df
fix: Consider an empty string header value to be present
jbelkins 6b0612a
Merge branch 'main' into jbe/empty_string_header_validation
jbelkins c75e7c4
Merge branch 'main' into jbe/empty_string_header_validation
jbelkins 802fc65
Merge branch 'main' into jbe/empty_string_header_validation
jbelkins 6b07c0a
Merge branch 'main' into jbe/empty_string_header_validation
jbelkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,14 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* SPDX-License-Identifier: Apache-2.0. | ||
*/ | ||
// | ||
// Copyright Amazon.com Inc. or its affiliates. | ||
// All Rights Reserved. | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
import SmithyHTTPAPI | ||
import XCTest | ||
import ClientRuntime | ||
|
||
class HttpHeadersTests: XCTestCase { | ||
class HeadersTests: XCTestCase { | ||
|
||
var headersAsDictionaryWithArray = [String: [String]]() | ||
var headersAsDictionary = [String: String]() | ||
|
@@ -123,4 +124,21 @@ class HttpHeadersTests: XCTestCase { | |
XCTAssertEqual(headerA, headerB) | ||
XCTAssertEqual(headerA.hashValue, headerB.hashValue) | ||
} | ||
|
||
// MARK: - exists() | ||
|
||
func test_exists_trueIfHeaderExists() { | ||
let subject = Headers(["a": "abc"]) | ||
XCTAssertTrue(subject.exists(name: "a")) | ||
} | ||
|
||
func test_exists_falseIfHeaderDoesntExist() { | ||
let subject = Headers(["a": "abc"]) | ||
XCTAssertFalse(subject.exists(name: "b")) | ||
} | ||
|
||
func test_exists_trueIfHeaderValueIsEmptyString() { | ||
let subject = Headers(["a": ""]) | ||
XCTAssertTrue(subject.exists(name: "a")) | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These new tests check the expected behavior for the |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous definition of
exists
was wrong because it considered a header with an empty string for its value to "not exist". Turns out a header with empty string value is valid, so it should definitely "exist".I suspect that the reason for this logic is that the previous developers changed the definition of "exists" to suit the behavior demanded by empty-header protocol tests, which is wrong and is being fixed by Smithy team.