-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server] Implement Gradle subprojects and scaffolding for the Python server. #1366
Conversation
There is a failing CI action, but it is expected as I am creating a bunch of new projects and the diff tool will need them on |
tasks.register<Exec>(Cargo.CHECK.toString) { | ||
workingDir("$buildDir/$workingDirUnderBuildDir") | ||
environment("RUSTFLAGS", defaultRustFlags) | ||
commandLine("cargo", "check") | ||
dependsOn("assemble") | ||
} | ||
|
||
tasks.register<Exec>(Cargo.TEST.toString) { | ||
workingDir("$buildDir/$workingDirUnderBuildDir") | ||
environment("RUSTFLAGS", defaultRustFlags) | ||
commandLine("cargo", "test") | ||
dependsOn("assemble") | ||
} | ||
|
||
tasks.register<Exec>(Cargo.DOCS.toString) { | ||
workingDir("$buildDir/$workingDirUnderBuildDir") | ||
environment("RUSTDOCFLAGS", defaultRustDocFlags) | ||
commandLine("cargo", "doc", "--no-deps") | ||
dependsOn("assemble") | ||
} | ||
|
||
tasks.register<Exec>(Cargo.CLIPPY.toString) { | ||
workingDir("$buildDir/$workingDirUnderBuildDir") | ||
environment("RUSTFLAGS", defaultRustFlags) | ||
commandLine("cargo", "clippy") | ||
dependsOn("assemble") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's actually a way to share these between projects—I think the smithy project does it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about this.. I'll figure out how to do it. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried many things, but we really need the working dir which is defined in the build.gradle.kt, so I don't see how this can be shared between projects. Any pointers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not a blocker for this PR, I have created #1378 to track this issue and solve it once I figure out how :)
Motivation and Context
See #1367.
Description
Implement Gradle subprojects and scaffolding for the Python server.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.