fix: always serialize defaults #1302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected ArtifactsNo artifacts changed size |
lauzadis
approved these changes
Jun 20, 2025
| @@ -173,7 +173,7 @@ fun Model.defaultSettings( | |||
| sdkId: String = TestModelDefault.SDK_ID, | |||
| generateDefaultBuildFiles: Boolean = false, | |||
| nullabilityCheckMode: CheckMode = CheckMode.CLIENT_CAREFUL, | |||
| defaultValueSerializationMode: DefaultValueSerializationMode = DefaultValueSerializationMode.WHEN_DIFFERENT, | |||
| defaultValueSerializationMode: DefaultValueSerializationMode = DefaultValueSerializationMode.DEFAULT, | |||
There was a problem hiding this comment.
This was originally set to WHEN_DIFFERENT because serializing defaults caused problems with S3, can we double-check those model issues are now resolved?
Comment on lines
+276
to
+277
| requireNotNull(entries.find { it.value.equals(value, ignoreCase = true) }) { | ||
| "$value is not a valid DefaultValueSerializationMode, expected one of ${values().map { it.value }}" |
There was a problem hiding this comment.
Why did this comparison need to change?
There was a problem hiding this comment.
All of these tests were updated to use the previous value WHEN_DIFFERENT. Do we have tests for the new value ALWAYS?
0marperez
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves awslabs/aws-sdk-kotlin#1608
Description of changes
This change switches the default serialization mode from
WHEN_DIFFERENT(meaning only if the value has been changed from the default) toALWAYS(meaning...well, always). This is the current recommendation from Smithy and will offer more deterministic communication with services.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.