feat: Add authSchemePreference configuration
#1277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Apr 23, 2025
| useNestedBuilderBaseClass() | ||
|
|
||
| documentation = """ | ||
| The ordered preference of [AuthScheme] that this client will use. |
There was a problem hiding this comment.
Suggestion: The documentation looks good. I think it would help to be more explicit about the preference list not being a hard override of auth schemes. Some people might get confused when the auth scheme(s) they prefer isn't being used.
ianbotsf
approved these changes
Apr 25, 2025
Comment on lines
+19
to
+22
| val preferredSchemeName = preferredSchemeId.id.substringAfter('#') | ||
| authOptions.singleOrNull { | ||
| it.schemeId.id.substringAfter('#') == preferredSchemeName | ||
| } |
There was a problem hiding this comment.
Question: Why are we dropping the prefix for this comparison?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.