misc: Downgrade clock skew exception stack trace to debug level
#1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Aug 23, 2024
| @@ -89,7 +89,8 @@ public class ClockSkewInterceptor : HttpInterceptor { | |||
| try { | |||
| Instant.fromRfc5322(it) | |||
| } catch (e: ParseException) { | |||
| logger.warn(e) { "Service returned malformed \"Date\" header value \"$it\", skipping skew calculation" } | |||
| logger.warn { "Service returned malformed \"Date\" header value \"$it\", skipping skew calculation" } | |||
| logger.debug(e) { e.message.toString() } | |||
There was a problem hiding this comment.
Nit: Logging e.message is unnecessary since the logger should already include it. I'd just give a bit more context about where the error was encountered and leave it at that:
logger.debug(e) { "Error while parsing \"Date\" header from service response" }
logger.warn { "Service returned malformed \"Date\" header value \"$it\", skipping skew calculation" }
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.