Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(docs): handle case where sideMenu is already expanded on page load #1135

Merged
merged 2 commits into from
Aug 2, 2024
Merged

misc(docs): handle case where sideMenu is already expanded on page load #1135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e034788
Handle case where sideMenu is already expanded on page load
lauzadis Aug 2, 2024
a64f326
Handle undefined `sideMenuPartParent`
lauzadis Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/dokka-presets/scripts/accessibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ function ensureNavButtonInteractable() {
// Make the navButton focusable, add accessibility information
navButton.setAttribute('tabindex', '0');
navButton.setAttribute('role', 'button');
navButton.setAttribute('aria-expanded', 'false');

const sideMenuPartParent = navButton.closest(".sideMenuPart")
const navButtonExpanded = sideMenuPartParent ? (sideMenuPartParent.classList.contains('hidden') ? 'false' : 'true') : 'false'
navButton.setAttribute('aria-expanded', navButtonExpanded);

// Grab the page ID, use it for aria-label and aria-controls
const sectionName = navButton.parentElement.parentElement.getAttribute('pageid')
Expand Down
Loading