Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close CRT HttpStream on call completion #1134

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Aug 1, 2024

HttpStream returned from makeRequest "must be closed by the user thread making this request when it's done"

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner August 1, 2024 20:58

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Aug 2, 2024

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-client-engine-crt-jvm.jar 51,641 51,492 149 0.29%

@lauzadis lauzadis merged commit bfcc35c into main Aug 2, 2024
15 checks passed
@lauzadis lauzadis deleted the fix-close-crt-stream branch August 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants