Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: docs accessibility fixes #1118

Merged
merged 1 commit into from
Jul 11, 2024
Merged

misc: docs accessibility fixes #1118

merged 1 commit into from
Jul 11, 2024

Conversation

lauzadis
Copy link
Contributor

Round 2!

  • Ensure only one toggle-content button is inserted
    • I was sometimes seeing two toggle-content buttons
  • Insert a skip-to-main-content link on the first sideMenuPart
    • Clicking a sideMenuPart would throws the tab index back to the top, meaning you have to tab all the way through to your current sideMenuPart before you will reach the skip-to-main-content link. This change adds a skip-link to the first sideMenuPart and the data-active sideMenuPart to ensure this case is covered.
  • Update invocation of ensureNavButtonInteractable function
    • I wasn't seeing this function's effects on the prod docs, hopefully updating the way its invoked will fix this

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis
Only insert one toggle-content button. Insert a skip link on the firs…
e48985a 
…t sideMenuPart. Update invocation of `ensureNavButtonInteractable` function.
@lauzadis lauzadis requested a review from a team as a code owner July 10, 2024 17:39
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jul 10, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions
Copy link

Affected Artifacts

No artifacts changed size

@lauzadis lauzadis merged commit 823372c into main Jul 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@0marperez 0marperez 0marperez approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauzadis @0marperez @ianbotsf