fix: outdated business metric ids #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Jul 8, 2024
| ACCOUNT_ID_BASED_ENDPOINT("O"), | ||
| SIGV4A_SIGNING("P"), | ||
| ENDPOINT_OVERRIDE("N"), | ||
| ACCOUNT_ID_ENDPOINT("O"), |
There was a problem hiding this comment.
Can we also emit the new ACCOUNT_ID_MODE_PREFERRED, ACCOUNT_ID_MODE_DISABLED, ACCOUNT_ID_MODE_REQUIRED metrics?
There was a problem hiding this comment.
Yeah, we can add that
0marperez
added
the
acknowledge-api-break
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Jul 17, 2024
ianbotsf
reviewed
Jul 17, 2024
There was a problem hiding this comment.
Question: This is an binary-compat breaking change and I see the acknowledge-api-break tag applied to the PR. Why do we think this is safe to release? Isn't this precisely the kind of API change that can bite customers if they're using specific versions of smithy-kotlin different from aws-sdk-kotlin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
The name of these metrics changed, so this PR updates them
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.