-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: upgrade to Kotlin 2.0.0 #1105
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
9c769f3
latest
lauzadis 0fee903
latest
lauzadis da64f87
latest
lauzadis 0ab6533
latest
lauzadis b9d1626
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis 9de13a4
Compiles
lauzadis 35b6157
changelog
lauzadis 09fa097
Take full dependency, not RC
lauzadis 4179c4e
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis f6cc850
upgrade to 0.4.7
lauzadis e4d5aa3
upgrade coroutines and atomicfu too
lauzadis ad72554
ktlint
lauzadis 9f35f07
atomicfu plugin only needs to be applied in the top-level build file
lauzadis 184e0d3
Revert "atomicfu plugin only needs to be applied in the top-level bui…
lauzadis bcc160b
Fix jvmAndNative source set
lauzadis a510dde
Fix deprecation warning
lauzadis 03ec8a7
ktlint
lauzadis 3f46eb9
remove comment
lauzadis 3cc38d3
Typealias no longer works :(
lauzadis ae7239f
passes now... ¯\_(ツ)_/¯
lauzadis 4f21bf9
`BigDecimal` needs to override `equals` function to get tests passing
lauzadis 195419c
apiDump
lauzadis 46f19a9
Upgrade kotlin-compile-testing and optin to their new `ExperimentalCo…
lauzadis fef00b0
Fix implementation of `equals` in `BigIntegerJvm`
lauzadis 2ef4539
ktlint
lauzadis d667f30
Upgrade to snapshot plugin version
lauzadis c82dc97
Upgrade to latest aws-kotlin-repo-tools plugin
lauzadis c93b3aa
Fix compiler warning
lauzadis 018e2cf
disable `kotlinWarningsAsErrors` for all-platforms CI
lauzadis 070858f
disable `kotlinWarningsAsErrors` for all-platforms CI
lauzadis c3b4247
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis b3316a9
Latest package transformation config
lauzadis 3120167
Share value
lauzadis 8ade075
remove comment
lauzadis f3a6ecb
reverted
lauzadis aa82a1f
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis ab46ea8
merge from main
lauzadis c91ec04
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis d7ef91b
latest
lauzadis b482091
Merge branch 'main' of github.com:smithy-lang/smithy-kotlin into misc…
lauzadis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"id": "a44842e7-3418-48ce-b2a9-99718c72c43b", | ||
"type": "misc", | ||
"description": "⚠️ **IMPORTANT**: Upgrade to Kotlin 2.0.0", | ||
"requiresMinorVersionBump": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,11 @@ public expect class TelemetryContextElement(context: Context) : CoroutineContext | |
public companion object Key : CoroutineContext.Key<TelemetryContextElement> | ||
|
||
public val context: Context | ||
override val key: CoroutineContext.Key<*> | ||
override fun <E : CoroutineContext.Element> get(key: CoroutineContext.Key<E>): E? | ||
override fun <R> fold(initial: R, operation: (R, CoroutineContext.Element) -> R): R | ||
override fun plus(context: CoroutineContext): CoroutineContext | ||
override fun minusKey(key: CoroutineContext.Key<*>): CoroutineContext | ||
} | ||
Comment on lines
17
to
25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: The K2 migration guide shows overriding abstract members with the |
||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Without this suppression which error(s) are seen? Just errors related to
@Suppress("INAPPLICABLE_JVM_NAME")
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's the only one. Since K2, they have started giving warnings for using this suppression, but the warning will be disabled again soon.