Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implicit task dependencies #1076

Closed
wants to merge 2 commits into from
Closed

fix: implicit task dependencies #1076

wants to merge 2 commits into from

Conversation

0marperez
Copy link
Contributor

@0marperez 0marperez commented Apr 23, 2024 •
edited
Loading

Issue #

N/A

Description of changes

Fix some implicit task dependencies gradle was marking as errors, e.g.

A problem was found with the configuration of task ':tests:codegen:nullability-tests:generateSmithyProjections' (type 'SmithyBuildTask').
  - Gradle detected a problem with the following location: '/.../smithy-kotlin/tests/codegen/nullability-tests/build/smithyprojections/nullability-tests'.
    
    Reason: Task ':tests:codegen:nullability-tests:kotlinSourcesJar' uses this output of task ':tests:codegen:nullability-tests:generateSmithyProjections' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Apr 23, 2024
@0marperez 0marperez marked this pull request as ready for review April 23, 2024 20:01
@0marperez 0marperez requested a review from a team as a code owner April 23, 2024 20:02
@0marperez 0marperez closed this Apr 24, 2024
@0marperez
Copy link
Contributor Author

Will be handled by: #1077

sullis pushed a commit to sullis/smithy-kotlin that referenced this pull request Jun 3, 2024
@0marperez
misc: start testing RestXmlXmlMapWithXmlNamespace (smithy-lang#1076)
e74ba21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0marperez