Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: added cause to unsupported signing algorithm exception #1036

Merged
merged 4 commits into from
Feb 15, 2024
Merged

misc: added cause to unsupported signing algorithm exception #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cabf9d1
Added cause to UnsupportedSigningAlgorithmException
0marperez Feb 12, 2024
2413de5
Api dump
0marperez Feb 12, 2024
bde30e3
Added missing Kdocs
0marperez Feb 13, 2024
b929ebc
Preserve API compatibility
0marperez Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions runtime/auth/aws-signing-common/api/aws-signing-common.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ public final class aws/smithy/kotlin/runtime/auth/awssigning/PresignerKt {

public final class aws/smithy/kotlin/runtime/auth/awssigning/UnsupportedSigningAlgorithmException : aws/smithy/kotlin/runtime/ClientException {
public fun <init> (Ljava/lang/String;Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAlgorithm;)V
public fun <init> (Ljava/lang/String;Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAlgorithm;Ljava/lang/Throwable;)V
public synthetic fun <init> (Ljava/lang/String;Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAlgorithm;Ljava/lang/Throwable;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun getSigningAlgorithm ()Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAlgorithm;
}

Expand Down
19 changes: 17 additions & 2 deletions ...gning-common/common/src/aws/smithy/kotlin/runtime/auth/awssigning/AwsSigningExceptions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,25 @@ import aws.smithy.kotlin.runtime.InternalApi
*
* See: [AwsSigningAlgorithm], [AwsSigner]
*
* @param isSigV4a Whether the unsupported signing algorithm is sigV4a
* @param message The message displayed by the exception
* @param signingAlgorithm The unsupported signing algorithm
Copy link
Contributor

@lauzadis lauzadis Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @param message, @param cause

* @param cause The cause of the exception
*/
@InternalApi
public class UnsupportedSigningAlgorithmException(
message: String,
public val signingAlgorithm: AwsSigningAlgorithm,
) : ClientException(message)
cause: Throwable? = null,
) : ClientException(
message,
cause,
) {
public constructor(
message: String,
signingAlgorithm: AwsSigningAlgorithm,
) : this (
message,
signingAlgorithm,
null,
)
}
Loading