feat: support S3 Express One Zone #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
approved these changes
Feb 21, 2024
...e/auth/aws-signing-crt/jvm/src/aws/smithy/kotlin/runtime/auth/awssigning/crt/CrtAwsSigner.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| @InternalApi | ||
| public class Md5ChecksumInterceptor<I>( | ||
| private val block: ((input: I) -> Boolean)? = null, | ||
| ) : HttpInterceptor { | ||
| private var cachedChecksum: String? = null |
There was a problem hiding this comment.
I don't quite understand what would break. Md5ChecksumInterceptor and FlexibleChecksumsRequestIntereceptor are final so it seems like users can't create their own custom implementations.
...http-client/common/src/aws/smithy/kotlin/runtime/http/interceptors/Md5ChecksumInterceptor.kt
Outdated
Show resolved
Hide resolved
aajtodd
reviewed
Feb 26, 2024
...e/auth/aws-signing-crt/jvm/src/aws/smithy/kotlin/runtime/auth/awssigning/crt/CrtAwsSigner.kt
Outdated
Show resolved
Hide resolved
...client/common/src/aws/smithy/kotlin/runtime/http/interceptors/AbstractChecksumInterceptor.kt
Show resolved
Hide resolved
...client/common/src/aws/smithy/kotlin/runtime/http/interceptors/AbstractChecksumInterceptor.kt
Outdated
Show resolved
Hide resolved
| public class LruCache<K, V>( | ||
| public val capacity: Int, | ||
| ) { | ||
| private val mu = Mutex() // protects map |
There was a problem hiding this comment.
thought: What if we just made this cache explicitly not thread safe and make synchronization a higher level concern? That would make things like entries and other fields thread safe if needed and allow locking to be at whatever granularity makes sense.
Just a thought.
…ing` to handle input changing through interceptors
…ing` to handle input changing through interceptors
aajtodd
approved these changes
Feb 28, 2024
|
lauzadis
added
the
acknowledge-api-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some features in order to support the SDK making S3 Express requests
Issue #
Description of changes
HttpOperationContext.ChecksumAlgorithm. The value is the name of the checksum algorithm to be used. If it's set when flexible checksums runs, it will be used, otherwise theContent-MD5header will be computed and added as before. This greatly simplifies the logic required in these interceptors.omitSessionTokensigning configuration via execution context, using theAwsSigningAttributes. OmitSessionTokenkey.LruCachewhich holds entries up to a configurablecapacityand then evicts the least-recently used entries as more are added.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.