chore: refactor build to use custom smithy build plugin #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Dec 29, 2023
|
|
||
| tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> { | ||
| dependsOn(generateSdk) | ||
| dependsOn(tasks.generateSmithyProjections) | ||
| // generated code has warnings unfortunately |
There was a problem hiding this comment.
nit: can link this issue as a FIXME: awslabs/aws-sdk-kotlin#1169 (just converted now from the internal issue)
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "version": "1.0", | |||
| "sources": ["model"], | |||
There was a problem hiding this comment.
question: why doesn't this need to reference a .smithy file like the other smithy-build.json files?
There was a problem hiding this comment.
It can be a directory or file. https://smithy.io/2.0/guides/building-models/build-config.html
0marperez
approved these changes
Dec 29, 2023
aajtodd
added
the
no-changelog
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Refactors the build to use our new codegen plugin based on the newer smithy gradle base plugin.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.