Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent mode showing when flag is present #326

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Sep 5, 2024

This fixes and issue where agent mode is showing when the flag is not present.

Testing

Test the production by adding the following the the config, the agent mode use show app
use_new_component: true

Test this brach with the same config the agent mode should not show up
use_new_component: true

@ayinloya ayinloya self-assigned this Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-fix-agent-mode-showing-by-default/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-fix-agent-mode-showing-by-default/js/script.min.js

Copy link
Contributor

@beastawakens beastawakens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayinloya ayinloya merged commit acabd69 into main Sep 5, 2024
10 checks passed
@ayinloya ayinloya deleted the fix-agent-mode-showing-by-default branch September 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants