Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide_attribution config #318

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Add hide_attribution config #318

merged 6 commits into from
Aug 28, 2024

Conversation

ayinloya
Copy link
Collaborator

We can now hide attribution by using hide_attribution in the config.

  • Add hide_attribution: true to the config in the example script
  • Run the example app
  • Verify that the attributions are hidden on all screen for each product
  • Run without setting hide_attribution and confirm the attributions are visible

@ayinloya ayinloya self-assigned this Aug 28, 2024
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-allow-hiding-attribution/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-allow-hiding-attribution/js/script.min.js

@ayinloya ayinloya marked this pull request as ready for review August 28, 2024 19:16
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-allow-hiding-attribution/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-allow-hiding-attribution/js/script.min.js

Copy link
Contributor

@beaglebets beaglebets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in reading this as defaulting to hidden?

@ayinloya
Copy link
Collaborator Author

Am I correct in reading this as defaulting to hidden?

Yes, there’s a flicker when the default is show and then we try to hid it

@beaglebets
Copy link
Contributor

so how does that get rendered? Would a partner have to explicitly enable it? Who would do that?

@ayinloya
Copy link
Collaborator Author

so how does that get rendered? Would a partner have to explicitly enable it? Who would do that?

We first check to see if there partner has set a config to hide the attribution if set it’ll remain hidden else it’ll show
we are only defaulting to hidden on the loading screen

Copy link
Contributor

@beaglebets beaglebets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the default were true, but I trust you ran this by product first.

@ayinloya ayinloya merged commit 1631385 into main Aug 28, 2024
10 checks passed
@ayinloya ayinloya deleted the allow-hiding-attribution branch August 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants