-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hide_attribution config #318
Conversation
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in reading this as defaulting to hidden?
Yes, there’s a flicker when the default is show and then we try to hid it |
so how does that get rendered? Would a partner have to explicitly enable it? Who would do that? |
We first check to see if there partner has set a config to hide the attribution if set it’ll remain hidden else it’ll show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if the default were true, but I trust you ran this by product first.
We can now hide attribution by using
hide_attribution
in the config.hide_attribution: true
to the config in the example scripthide_attribution
and confirm the attributions are visible