Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of not loading green book through id_selection config #309

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

solnsubuga
Copy link
Contributor

@solnsubuga solnsubuga commented Aug 14, 2024

In this PR, we fix an issue that Ope highlighted on standup where if user add to config the following?

 id_selection: {
     ZA: ['IDENTITY_CARD'],
 },

It would only load the identity card and not the green book. This fix ensures when the IDENTITY_CARD is used for country ZA it loads both the identity card and green book.

@solnsubuga solnsubuga self-assigned this Aug 14, 2024
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-sn/fix-issue-not-loading-green-book/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-sn/fix-issue-not-loading-green-book/js/script.min.js

@solnsubuga solnsubuga force-pushed the sn/fix-issue-not-loading-green-book branch 2 times, most recently from 6cdf4f0 to 8411f48 Compare August 15, 2024 11:36
@solnsubuga solnsubuga force-pushed the sn/fix-issue-not-loading-green-book branch from 8411f48 to 851bf5b Compare August 15, 2024 11:57
Copy link
Collaborator

@ayinloya ayinloya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solnsubuga solnsubuga merged commit 3990bb6 into main Aug 15, 2024
10 checks passed
@solnsubuga solnsubuga deleted the sn/fix-issue-not-loading-green-book branch August 15, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants