-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebComponents]Updated colour theme #305
Conversation
Add theme color control to selfie instruction stories
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sent the theme_colour in scripts.js to a prefered color but the app buttons and theming was blue.
What is expected to change in this case? Can we also add some UI images to the PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great improvement. I would be much happier if I were re-approving this after tests were updated to show that we pass the theme color in.
Added test for color |
This change makes use of the colour theme provided in the web embed to change the colour or buttons and headers texts.
Testing
Update the
theme_color
to the preferred colour in the example appRun the example app and confirm the colour is applied