Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebComponents]Updated colour theme #305

Merged
merged 18 commits into from
Aug 15, 2024
Merged

[WebComponents]Updated colour theme #305

merged 18 commits into from
Aug 15, 2024

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Aug 8, 2024

This change makes use of the colour theme provided in the web embed to change the colour or buttons and headers texts.

Testing

Update the theme_color to the preferred colour in the example app
Run the example app and confirm the colour is applied

Screenshot 2024-08-12 at 4 32 36 PM

Copy link

github-actions bot commented Aug 8, 2024

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-updated-color-theme/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-updated-color-theme/js/script.min.js

Copy link
Contributor

@solnsubuga solnsubuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent the theme_colour in scripts.js to a prefered color but the app buttons and theming was blue.

What is expected to change in this case? Can we also add some UI images to the PR?

@ayinloya
Copy link
Collaborator Author

I have sent the theme_colour in scripts.js to a prefered color but the app buttons and theming was blue.

What is expected to change in this case? Can we also add some UI images to the PR?

theme_colour should be part of the partner_details

Copy link
Contributor

@beaglebets beaglebets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement. I would be much happier if I were re-approving this after tests were updated to show that we pass the theme color in.

@ayinloya
Copy link
Collaborator Author

I think this is a great improvement. I would be much happier if I were re-approving this after tests were updated to show that we pass the theme color in.

Added test for color

@ayinloya ayinloya merged commit 09173e8 into main Aug 15, 2024
10 checks passed
@ayinloya ayinloya deleted the updated-color-theme branch August 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants