[WebComponents] Enh document capture margins #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
Add height and width attributes
Reuse this._drawLandscapeImage for summited image when in landscape mode Refactor _drawLandscapeImage to accept scaleheight and width
ayinloya
changed the title
|
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
* Handle Portrait Mode for documents like green card * Fix missing function error
beaglebets
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the capture of documents by adding extra margins to the submitted image.
https://app.shortcut.com/smileid/story/13030/add-extra-margins-when-capturing-documents-to-prevent-overcropping-on-web-component
Testing
Example App
The Example App can be used to test out changes made locally to the embed and it's dependencies.
To start testing locally with the embed
Copy the Sample env to example/.env in the example app and provide the relevant values
Build and start the embed server (it should be running on port 8000)
cd packages/embed npm install npm build npm startStart the example app
cd example npm install npm start npm run dev