Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move Combobox component from embed to components package #139

Closed
wants to merge 1 commit into from
Closed

refactor: move Combobox component from embed to components package #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "@smile_identity/smart-camera-web",
"name": "@smileid/components",
"version": "1.0.2",
"description": "WebComponent for smartly capturing images on the web, for use with SmileIdentity",
"main": "smart-camera-web.js",
"scripts": {
"build": "npx nyc instrument --compact=false smart-camera-web.js cypress/pages/instrumented",
"start": "npx serve -p 8000 cypress/pages",
Expand All @@ -17,6 +16,10 @@
"WebComponent",
"WebRTC"
],
"exports": {
".": "./src/components/index.js",
"./smart-camera-web": "./smart-camera-web.js"
},
"files": [
"smart-camera-web.js"
],
Expand Down
0 packages/embed/src/js/components/Combobox.js → ...ges/components/src/components/Combobox.js
View file
Open in desktop
File renamed without changes.
3 changes: 3 additions & 0 deletions packages/components/src/components/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import ComboboxComponents from './Combobox';

export const Combobox = ComboboxComponents;
2 changes: 1 addition & 1 deletion packages/embed/src/js/basic-kyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import validate from "validate.js";
import ConsentScreen from "./components/ConsentScreen";
import TotpBasedConsent from "./components/TotpConsentApp";
import Combobox from "./components/Combobox";
import { Combobox } from "@smileid/components";
import { version as sdkVersion } from "../../package.json";

(function basicKyc() {
Expand Down
4 changes: 2 additions & 2 deletions packages/embed/src/js/doc-verification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import "@smile_identity/smart-camera-web";
import "@smileid/components/smart-camera-web";
import JSZip from "jszip";
import { version as sdkVersion } from "../../package.json";
import Combobox from "./components/Combobox";
import { Combobox } from "@smileid/components";

(function documentVerification() {
"use strict";
Expand Down
2 changes: 1 addition & 1 deletion packages/embed/src/js/ekyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import validate from "validate.js";
import ConsentScreen from "./components/ConsentScreen";
import TotpBasedConsent from "./components/TotpConsentApp";
import Combobox from "./components/Combobox";
import { Combobox } from "@smileid/components";
import { version as sdkVersion } from "../../package.json";

(function eKYC() {
Expand Down
Loading