Start to support Overleaf 5.1.1 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! It seems that there may be an issue with LDAP. I should have some time over the weekend to take a look at it. Updated: Sorry for the delay. I have to mention that this project requires a better development environment. it's quite difficult to debug with LDAP at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR was made to try to make #50 progress.
I used two great sources to begin this pull request:
The purpose behind this PR is to propose only changes related to 5.1.1 support. This pull request does not provide a complete support for 5.1.1
Suggestions and review are really welcome. If this PR can help someone in the process of updating ldap-overleaf-sl to support Overleaf 5.1.1, feel free to use it and improve it.
Implemented changes
OVERLEAFnavbar.pugbynavbar-website-redesign.pugOAuth 2
OAuth 2 was tried against a provider, and should work. Only a few changes were related to OAuth.
LDAP
LDAP features are partially updated for 5.1.1. Changes made are mostly related to the use of the promise based syntax.
Currently, LDAP features does not work, and are commented out in this PR.
If someone manages to fix them, help would be really appreciated.
Update to V5
Migrations steps are required to update to V5, especially for the database migration.
Users should also update environment variables and volume mounts : https://github.com/overleaf/overleaf/wiki/Release-Notes-5.x.x#mongodb-upgrade-to-v5
Documentation needs to be written on this subject
close #50