Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for active OAuth to login route #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xathon
Copy link

@xathon xathon commented Jan 5, 2024

This adds a way to directly skip the login page when OAuth is enabled.

If needed, there could be a variable to enable this, although I don't see the value since adding the OAuth provider broke the regular login for me anyway.

Fixes #42 .

@yzx9 yzx9 self-requested a review January 6, 2024 05:56
@yzx9 yzx9 added the enhancement New feature or request label Jan 9, 2024
@yzx9
Copy link
Collaborator

yzx9 commented Jan 15, 2024

Should we reuse the ALLOW_EMAIL_LOGIN option? Although it differs somewhat from the current semantics.

Update: Furthermore, we can introduce an option to disable LDAP login, given that OAuth2 authentication operates independently. Consequently, this PR does not require the inclusion of a new option.

@yzx9
Copy link
Collaborator

yzx9 commented Mar 2, 2024

I prefer to introduce a new option LDAP_ENABLED, ensuring redirection occurs only when both email and LDAP logins are disabled. This option should also be added to the LDAP entry.

Additionally, disabling the login page may result in an infinite redirection loop. If OAuth login fails, we redirect to the /login page, which then redirects back to /oauth/redirect, creating a continuous cycle.

smhaller added a commit that referenced this pull request Jun 26, 2024
…oes not use ldap but oauth - then there is no login page but a redirect to the oauth provider. Closes issue #42 and pull request #43.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an option to skip login page if OAuth provider is registered
2 participants