update jquery.js, jquery-ui.js, and moment.js #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any chances for this PR to get merged? |
|
+1 |
1 similar comment
|
+1 |
Open
|
@riannucci @andresperezl When will this get merged , looks like there are multiple vulnerabilities and whitesource is showing this package as vulnerable. |
|
Did you actually test these to ensure the goconvey UI still works after this? |
|
(that's why I haven't been merging these; last time I tried one of these pulls locally the UI fell apart and I didn't have time to investigate what went wrong) |
|
We stopped using goconvey, so I can close this, and let someone try the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Open Source vulnerabilities scanners will mark
goconveyas vulnerable because of the versions ofjquery,jquery-ui, andmoment.js(moment.jsis actually marked as HIGH). Even if the vulnerable parts are not used, this can prevent some organizations of integrating goconvey on their code because of it.CVEs addressed: