Executor Plugin: Improvements and fixes #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hs are available instead of (non existing) item name references
…e functions. Now the plugin can be used immediately without having to wait for fetching the autocomplete dict.
…"id" were fetched wrongly
|
It looks fine, just go ahead and merge it. Thank you for the improvements! |
|
Maybe we can find a convenient way to deliver some sample skripts as well. Do you have an idea? Maybe a subdir within the plugin folder which will be merged into the list and that are readonly and colorized within the list? |
|
Including "standard" examples in a sub-dir sounds fine for me. Also the idea of putting them in the list with different color (grey?, maybe italic font?). Just the 3 examples from the documentation? |
bmxp
reviewed
Jul 10, 2023
executor/user_doc.rst
Outdated
| @@ -16,7 +16,7 @@ executor | |||
| Einführung | |||
| ~~~~~~~~~~ | |||
|
|
|||
| Das executor plugin kann genutzt werden, um **Python Code** (z.B. für **Logiken**) und **eval Ausdrücke** zu testen. | |||
| Das executor Plugin kann genutzt werden, um **Python Code** (z.B. für **Logiken**) und **eval Ausdrücke** zu testen. | |||
There was a problem hiding this comment.
Das mit den eval Ausdrücken kann raus, die sind ja im Admin Interface bereits implementiert.
bmxp
approved these changes
Jul 10, 2023
| @@ -197,7 +197,7 @@ def eval_statement(self, eline, path, reload=None): | |||
| def exec_code(self, eline, reload=None): | |||
| """ | |||
| evaluate a whole python block in eline | |||
|
|
|||
| :return: result of the evaluation | |||
| """ | |||
| result = "" | |||
There was a problem hiding this comment.
der stub_logger müsste noch um neuere methoden wie notice etc. erweitert werden...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major fix for autocomplete
Performance improvements (loading autocomplete takes 15s for me and blocked the webif..)
Sorting option for saved files