Skip to content

Commit 7a2581a

Browse files
authored
Merge pull request #420 from smartdevicelink/bugfix/align-keyboard-listener
Align Keyboard Listener
2 parents 5f780b7 + 650ca6e commit 7a2581a

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/js/src/manager/screen/choiceset/KeyboardListener.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class KeyboardListener {
4646
this._updateAutocompleteWithInput = null;
4747
this._updateCharacterSetWithInput = null;
4848
this._onKeyboardDidSendEvent = null;
49-
this._onKeyboardInputMaskHasChanged = null;
49+
this._onKeyboardDidUpdateInputMask = null;
5050
}
5151

5252
/**
@@ -100,12 +100,12 @@ class KeyboardListener {
100100
}
101101

102102
/**
103-
* Set the onKeyboardInputMaskHasChanged function.
103+
* Set the onKeyboardDidUpdateInputMask function.
104104
* @param {function} listener - A function to be invoked when the event occurs.
105105
* @returns {KeyboardListener} - A reference to this instance to allow method chaining.
106106
*/
107-
setOnKeyboardInputMaskHasChanged (listener) {
108-
this._onKeyboardInputMaskHasChanged = listener;
107+
setOnKeyboardDidUpdateInputMask (listener) {
108+
this._onKeyboardDidUpdateInputMask = listener;
109109
return this;
110110
}
111111

@@ -175,13 +175,13 @@ class KeyboardListener {
175175
}
176176

177177
/**
178-
* Safely attempts to invoke the onKeyboardInputMaskHasChanged event.
178+
* Safely attempts to invoke the onKeyboardDidUpdateInputMask event.
179179
* Implement this to be notified of all events occurring on the keyboard
180180
* @param {KeyboardEvent} event - The event that occurred
181181
*/
182-
onKeyboardInputMaskHasChanged (event) {
183-
if (typeof this._onKeyboardInputMaskHasChanged === 'function') {
184-
this._onKeyboardInputMaskHasChanged(event);
182+
onKeyboardDidUpdateInputMask (event) {
183+
if (typeof this._onKeyboardDidUpdateInputMask === 'function') {
184+
this._onKeyboardDidUpdateInputMask(event);
185185
}
186186
}
187187
}

lib/js/src/manager/screen/choiceset/_PresentChoiceSetOperation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ class _PresentChoiceSetOperation extends _Task {
307307
// notify of abort / cancelation
308308
this._keyboardListener.onKeyboardDidAbortWithReason(onKeyboardInput.getEvent());
309309
} else if (onKeyboardInput.getEvent() === KeyboardEvent.INPUT_KEY_MASK_ENABLED || onKeyboardInput.getEvent() === KeyboardEvent.INPUT_KEY_MASK_DISABLED) {
310-
this._keyboardListener.onKeyboardInputMaskHasChanged(onKeyboardInput.getEvent());
310+
this._keyboardListener.onKeyboardDidUpdateInputMask(onKeyboardInput.getEvent());
311311
}
312312
};
313313

lib/js/src/manager/screen/choiceset/_PresentKeyboardOperation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ class _PresentKeyboardOperation extends _Task {
250250
// notify of abort / cancelation
251251
this._keyboardListener.onKeyboardDidAbortWithReason(onKeyboardInput.getEvent());
252252
} else if (onKeyboardInput.getEvent() === KeyboardEvent.INPUT_KEY_MASK_ENABLED || onKeyboardInput.getEvent() === KeyboardEvent.INPUT_KEY_MASK_DISABLED) {
253-
this._keyboardListener.onKeyboardInputMaskHasChanged(onKeyboardInput.getEvent());
253+
this._keyboardListener.onKeyboardDidUpdateInputMask(onKeyboardInput.getEvent());
254254
}
255255
};
256256

0 commit comments

Comments
 (0)