Merge pull request #416 from smartdevicelink/bugfix/alert_buttons_limit

renonick87 · web-flow · commit 5f780b75d3ad · 2021-03-26T16:56:58.000-04:00
Fix AlertManager to limit Alerts to 4 soft buttons and trim the list …
diff --git a/lib/js/src/manager/screen/utils/_PresentAlertOperation.js b/lib/js/src/manager/screen/utils/_PresentAlertOperation.js
@@ -304,7 +304,7 @@ class _PresentAlertOperation extends _Task {
 
         if (this._alertView.getSoftButtons() !== null) {
             const softButtons = [];
-            for (let index = 0; index < this._alertView.getSoftButtons().length; index++) {
+            for (let index = 0; index < this._getSoftButtonCount(); index++) {
                 softButtons.push(this._alertView.getSoftButtons()[index].getCurrentStateSoftButton());
             }
             alert.setSoftButtons(softButtons);

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ class _PresentAlertOperation extends _Task {`
`304`	`304`
`305`	`305`	`if (this._alertView.getSoftButtons() !== null) {`
`306`	`306`	`const softButtons = [];`
`307`		`- for (let index = 0; index < this._alertView.getSoftButtons().length; index++) {`
	`307`	`+ for (let index = 0; index < this._getSoftButtonCount(); index++) {`
`308`	`308`	`softButtons.push(this._alertView.getSoftButtons()[index].getCurrentStateSoftButton());`
`309`	`309`	`}`
`310`	`310`	`alert.setSoftButtons(softButtons);`