Revise 0280 - Adding new parameter of requires audio support and bluetoothDeviceAddress #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2020 14:17
…ort and BluetoothDeviceAddress
…d BluetoothDeviceAddress
…ort and BluetoothDeviceAddress
|
Hi, @theresalech -san. |
theresalech
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Hi @Akihiro-Miyazaki, thanks for your PR. I've left one question, and some suggested changes. Please let me know if you have any questions or concerns with addressing my comments. Thank you!
proposals/0280-Adding-new-parameter-of-requiresAudioSupport-and-BluetoothDeviceAddress.md
Outdated
Show resolved
Hide resolved
proposals/0280-Adding-new-parameter-of-requiresAudioSupport-and-BluetoothDeviceAddress.md
Show resolved
Hide resolved
…d-BluetoothDeviceAddress.md Co-authored-by: theresalech <[email protected]>
theresalech
requested changes
Sep 10, 2020
proposals/0280-Adding-new-parameter-of-requiresAudioSupport-and-BluetoothDeviceAddress.md
Outdated
Show resolved
Hide resolved
…d-BluetoothDeviceAddress.md Co-authored-by: theresalech <[email protected]>
|
Hi, @theresalech -san. |
theresalech
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is an update of SDL-0280.
Add "JavaScript Suite" in Impacted platforms.
Motivation
Add the description of other platforms(such as iOS and JavaScript Suite).
Proposed solution
Add the comment "This flow is only for Android devices.".
Replace the figure of registeringApp_flow.
MediaStreamingStatus.isAudioOutputAvailable.Add
BluetoothInfotoOnDeviceStateChanged.Impact on existing code
Add "JavaScript Suite" to impacted platforms.