Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams RWAs #86

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Streams RWAs #86

merged 1 commit into from
Oct 29, 2024

Conversation

khadni
Copy link
Contributor

@khadni khadni commented Oct 29, 2024 •
edited by github-actions bot
Loading

Below is a summarization created by an LLM (gpt-4-turbo-2024-04-09). Be mindful of hallucinations and verify accuracy.

Why

Enhances the StreamsUpkeepRegistrar contract by introducing new report schemas for crypto and RWA feeds, improving data accuracy and handling different decimal places.

What

  • StreamsUpkeepRegistrar.sol
    • Added error InvalidReportVersion for unsupported report versions
    • Replaced Report struct with ReportV3 and ReportV4 for different feed types
    • Changed variable s_last_retrieved_price to lastDecodedPrice
    • Updated comments and documentation links
    • Added logic to handle different report versions and validate them
  • getLastRetrievedPrice.js
    • Updated variable name from s_lastRetrievedPrice to lastDecodedPrice in task script

@khadni khadni merged commit b2f35e0 into main Oct 29, 2024
1 check passed
@khadni khadni deleted the streams-rwas branch October 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedriftofwords thedriftofwords thedriftofwords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khadni @thedriftofwords