Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dont Merge] Updates L2EP staleness threshold to 10 minutes #3287

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohamed-mehany
Copy link
Collaborator

@mohamed-mehany mohamed-mehany commented May 7, 2024

Closes SHIP-1751

Description

This PR updates the L2EP staleness threshold for block height check from 2 minutes to 10 minutes.

Changes

  • Updates the L2EP staleness threshold for block height check from 2 minutes to 10 minutes.

Steps to Test

  1. Unit test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: b8c2a23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/layer2-sequencer-health-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mohamed-mehany mohamed-mehany marked this pull request as draft May 10, 2024 06:24
@mohamed-mehany mohamed-mehany changed the title Updates L2EP staleness threshold to 10 minutes [Dont Merge] Updates L2EP staleness threshold to 10 minutes May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant