Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test_GetWrappedNativeTokenPriceUSD #16454

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix Test_GetWrappedNativeTokenPriceUSD #16454

merged 2 commits into from
Feb 18, 2025
+4 −4

Conversation

0xnogo
Copy link
Collaborator

@0xnogo 0xnogo commented Feb 18, 2025 •
edited
Loading

Assert that the price is present on the src not on dest (FeeQuoter is never called from dest reader)

@0xnogo 0xnogo changed the title Use src reader instead of dest Fix Test_GetWrappedNativeTokenPriceUSD Feb 18, 2025
@0xnogo 0xnogo marked this pull request as ready for review February 18, 2025 15:25
@0xnogo 0xnogo requested review from a team as code owners February 18, 2025 15:25
mateusz-sekara
mateusz-sekara previously approved these changes Feb 18, 2025
View reviewed changes
@0xnogo 0xnogo enabled auto-merge February 18, 2025 15:38
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@0xnogo 0xnogo added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit 9f8bce8 Feb 18, 2025
180 checks passed
@0xnogo 0xnogo deleted the ng/fix-reader-ccip branch February 18, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnogo @makramkd @mateusz-sekara