Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version #16441

Closed
wants to merge 2 commits into from
+3 −6
Closed

Bump version #16441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0669ad7
[fix] Remove SetDefaults() call which deletes enabled
cedric-cordenier Feb 17, 2025
ea5a8e6
Hack the version
cedric-cordenier Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core/services/chainlink/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,6 @@ func (c RawConfig) NodeNames() []string {
}

func (c RawConfig) SetDefaults() {
if e, ok := c["Enabled"].(bool); ok && e {
// already enabled by default so drop it
delete(c, "Enabled")
}
}

// TOMLString returns a TOML encoded string.
Expand Down
1 change: 1 addition & 0 deletions core/services/chainlink/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,6 +1799,7 @@ func TestRawConfig_IsEnabled(t *testing.T) {
}

func TestRawConfig_SetDefaults(t *testing.T) {
t.Skip()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the function doesn’t return or change anything, I suggest we update the test (that would check if nothing changed in the configuration) instead of skipping it.

c := RawConfig{"Enabled": true}
c.SetDefaults()
require.NotContains(t, c, "Enabled")
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chainlink",
"version": "2.20.0",
"version": "2.21.0",
"description": "node of the decentralized oracle network, bridging on and off-chain computation",
"main": "index.js",
"scripts": {
Expand All @@ -26,4 +26,4 @@
"@changesets/get-github-info": "^0.6.0",
"semver": "^7.6.3"
}
}
}
Loading