why fail?

[graham-chainlink]

       	Error Trace:	/Users/ggoh/work/chainlink/deployment/common/proposalutils/mcms_test_helpers.go:287
        	            				/Users/ggoh/work/chainlink/deployment/common/changeset/test_helpers.go:94
        	            				/Users/ggoh/work/chainlink/deployment/keystone/changeset/add_nodes_test.go:323
        	            				/Users/ggoh/work/chainlink/deployment/keystone/changeset/add_nodes_test.go:271
        	Error:      	Received unexpected error:
        	            	execution reverted: RBACTimelock: underlying transaction reverted
        	Test:       	TestAddNodes/with_mcms/error_-_unregistered_nop

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Undefined field Transactions in BatchChainOperation type: [Run Tests]

Source of Error:

Run Tests	2025-02-17T05:20:04.1671194Z ##[error]../../deployment/keystone/changeset/add_nodes.go:239:38: resp.Ops.Transactions undefined (type *"github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation has no field or method Transactions)

Why: The BatchChainOperation type from the ccip-owner-contracts package does not have a field or method named Transactions.

Suggested fix: Verify the structure of BatchChainOperation and ensure that the correct field or method is being accessed. Update the code to use the correct field or method.

2. Type mismatch in array or slice literal: [Run Tests]

Source of Error:

Run Tests	2025-02-17T05:20:04.1690720Z ##[error]../../deployment/keystone/changeset/add_nodes.go:261:27: cannot use *resp.Ops (variable of type "github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation) as "github.com/smartcontractkit/mcms/types".BatchOperation value in array or slice literal

Why: The BatchChainOperation type from the ccip-owner-contracts package is being used where a BatchOperation type from the mcms/types package is expected.

Suggested fix: Ensure that the correct type is being used in the array or slice literal. If necessary, convert or map the BatchChainOperation to BatchOperation.

3. Undefined field Transactions in BatchChainOperation type: [Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-02-17T05:21:29.1963712Z ##[error]keystone/changeset/add_nodes.go:239:38: resp.Ops.Transactions undefined (type *"github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation has no field or method Transactions)

Why: The BatchChainOperation type from the ccip-owner-contracts package does not have a field or method named Transactions.

Suggested fix: Verify the structure of BatchChainOperation and ensure that the correct field or method is being accessed. Update the code to use the correct field or method.

4. Type mismatch in array or slice literal: [Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-02-17T05:21:29.1967933Z ##[error]keystone/changeset/add_nodes.go:261:27: cannot use *resp.Ops (variable of type "github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation) as "github.com/smartcontractkit/mcms/types".BatchOperation value in array or slice literal (typecheck)

Why: The BatchChainOperation type from the ccip-owner-contracts package is being used where a BatchOperation type from the mcms/types package is expected.

Suggested fix: Ensure that the correct type is being used in the array or slice literal. If necessary, convert or map the BatchChainOperation to BatchOperation.

5. Unused variable contracts: [Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-02-17T05:21:29.1995074Z ##[error]deployment/keystone/changeset/add_capabilities_test.go:70:3: declared and not used: contracts (typecheck)

Why: The variable contracts is declared but not used in the code.

Suggested fix: Remove the unused variable contracts or use it appropriately in the code.

6. Missing type in composite literal: [Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-02-17T05:21:29.1997408Z ##[error]deployment/keystone/changeset/add_nodes_test.go:97:10: missing type in composite literal (typecheck)

Why: A composite literal is missing a type specification.

Suggested fix: Specify the type in the composite literal.

7. Unused variable contracts: [Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-02-17T05:21:29.2007398Z ##[error]deployment/keystone/changeset/add_nops_test.go:81:3: declared and not used: contracts (typecheck)

Why: The variable contracts is declared but not used in the code.

Suggested fix: Remove the unused variable contracts or use it appropriately in the code.

8. Undefined field Transactions in BatchChainOperation type: [Core Tests (go_core_ccip_deployment_tests)]

Source of Error:

Run tests	2025-02-17T05:21:55.5199960Z ##[error]keystone/changeset/add_nodes.go:239:38: resp.Ops.Transactions undefined (type *"github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation has no field or method Transactions)

Why: The BatchChainOperation type from the ccip-owner-contracts package does not have a field or method named Transactions.

Suggested fix: Verify the structure of BatchChainOperation and ensure that the correct field or method is being accessed. Update the code to use the correct field or method.

9. Type mismatch in array or slice literal: [Core Tests (go_core_ccip_deployment_tests)]

Source of Error:

Run tests	2025-02-17T05:21:55.5213170Z ##[error]keystone/changeset/add_nodes.go:261:27: cannot use *resp.Ops (variable of type "github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock".BatchChainOperation) as "github.com/smartcontractkit/mcms/types".BatchOperation value in array or slice literal

Why: The BatchChainOperation type from the ccip-owner-contracts package is being used where a BatchOperation type from the mcms/types package is expected.

Suggested fix: Ensure that the correct type is being used in the array or slice literal. If necessary, convert or map the BatchChainOperation to BatchOperation.