Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick core hotfix: chore: remove for in the reaper loop #16418

Conversation

ogtownsend
Copy link
Collaborator

@ogtownsend ogtownsend commented Feb 14, 2025

Cherry pick core hotfix to keep release branches in sync. From:

@ogtownsend ogtownsend requested review from a team as code owners February 14, 2025 18:53
@ogtownsend ogtownsend changed the title chore: remove for in the reaper loop Cherry pick core hotfix: chore: remove for in the reaper loop Feb 14, 2025
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Missing required module: go_core_tests

Source of Error:
core/services/relay/evm/capabilities/testutils/backend.go:20:2: no required module provides package github.com/smartcontractkit/chainlink-integrations/evm/heads/headstest; to add it:
	go get github.com/smartcontractkit/chainlink-integrations/evm/heads/headstest

Why: The Go test is failing because the package github.com/smartcontractkit/chainlink-integrations/evm/heads/headstest is not available in the module dependencies. This indicates that the required module is missing from the go.mod file.

Suggested fix: Add the missing module by running go get github.com/smartcontractkit/chainlink-integrations/evm/heads/headstest and ensure it is included in the go.mod file.

2. Missing required module: go_core_tests

Source of Error:
core/services/relay/evm/capabilities/testutils/backend.go:21:2: no required module provides package github.com/smartcontractkit/chainlink-integrations/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink-integrations/evm/logpoller

Why: The Go test is failing because the package github.com/smartcontractkit/chainlink-integrations/evm/logpoller is not available in the module dependencies. This indicates that the required module is missing from the go.mod file.

Suggested fix: Add the missing module by running go get github.com/smartcontractkit/chainlink-integrations/evm/logpoller and ensure it is included in the go.mod file.

@ogtownsend ogtownsend closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants