Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): solana ccip transfer ownership to timelock #16415

Closed

Conversation

gustavogama-cll
Copy link
Contributor

@gustavogama-cll gustavogama-cll commented Feb 14, 2025

Adds the changeset to transfer ownership of CCIP solana programs

DPA-1525

Copy link
Contributor

github-actions bot commented Feb 14, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Unused import error:go_core_tests

Source of Error:
core/capabilities/ccip/common/common_test.go:11:2: "github.com/smartcontractkit/chainlink-integrations/evm/assets" imported and not used
**Why**: The Go compiler detected an import statement for a package that is not being used in the code, which is not allowed in Go.

Suggested fix: Remove the unused import statement from the file common_test.go.

2. Missing import error:go_core_tests

Source of Error:
core/capabilities/ccip/common/common_test.go:12:2: could not import github.com/smartcontractkit/chainlink-integrations/evm/testutils (open : no such file or directory)
**Why**: The Go compiler could not find the specified package, possibly due to a typo in the import path or the package not being available.

Suggested fix: Verify the import path and ensure the package github.com/smartcontractkit/chainlink-integrations/evm/testutils exists and is accessible.

3. Unused import error:go_core_tests

Source of Error:
core/capabilities/integration_tests/framework/ethereum.go:17:2: "github.com/smartcontractkit/chainlink-integrations/evm/assets" imported and not used
**Why**: The Go compiler detected an import statement for a package that is not being used in the code, which is not allowed in Go.

Suggested fix: Remove the unused import statement from the file ethereum.go.

4. Missing import error:go_core_tests

Source of Error:
core/capabilities/integration_tests/framework/ethereum.go:18:2: could not import github.com/smartcontractkit/chainlink-integrations/evm/testutils (open : no such file or directory)
**Why**: The Go compiler could not find the specified package, possibly due to a typo in the import path or the package not being available.

Suggested fix: Verify the import path and ensure the package github.com/smartcontractkit/chainlink-integrations/evm/testutils exists and is accessible.

5. Unused import error:go_core_tests

Source of Error:
core/services/vrf/solidity_cross_tests/vrf_solidity_crosscheck_test.go:19:2: "github.com/smartcontractkit/chainlink-integrations/evm/assets" imported and not used
**Why**: The Go compiler detected an import statement for a package that is not being used in the code, which is not allowed in Go.

Suggested fix: Remove the unused import statement from the file vrf_solidity_crosscheck_test.go.

6. Missing import error:go_core_tests

Source of Error:
core/services/vrf/solidity_cross_tests/vrf_solidity_crosscheck_test.go:20:2: could not import github.com/smartcontractkit/chainlink-integrations/evm/testutils (open : no such file or directory)
**Why**: The Go compiler could not find the specified package, possibly due to a typo in the import path or the package not being available.

Suggested fix: Verify the import path and ensure the package github.com/smartcontractkit/chainlink-integrations/evm/testutils exists and is accessible.

7. Unused import error:go_core_tests

Source of Error:
core/services/vrf/solidity_cross_tests/vrf_v08_solidity_crosscheck_test.go:20:2: "github.com/smartcontractkit/chainlink-integrations/evm/assets" imported and not used
**Why**: The Go compiler detected an import statement for a package that is not being used in the code, which is not allowed in Go.

Suggested fix: Remove the unused import statement from the file vrf_v08_solidity_crosscheck_test.go.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@gustavogama-cll gustavogama-cll force-pushed the ggama/solana-ccip-transfer-ownership branch 3 times, most recently from 28bfb15 to 21e0713 Compare February 14, 2025 18:06
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 28bfb15 (ggama/solana-ccip-transfer-ownership).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployMCMSWithTimelockV2 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 43.086666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@gustavogama-cll gustavogama-cll force-pushed the ggama/solana-ccip-transfer-ownership branch 7 times, most recently from d67758a to e6710ff Compare February 14, 2025 20:57
Adds the changeset to transfer ownership of CCIP solana programs

[DPA-1525](https://smartcontract-it.atlassian.net/browse/DPA-1525)
@gustavogama-cll gustavogama-cll force-pushed the ggama/solana-ccip-transfer-ownership branch from e6710ff to 2f28357 Compare February 14, 2025 21:27
@gustavogama-cll gustavogama-cll deleted the ggama/solana-ccip-transfer-ownership branch February 15, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants