Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCIP-5235] integration-tests/smoke/ccip: update msging test #16408

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

makramkd
Copy link
Contributor

@makramkd makramkd commented Feb 14, 2025

Update the messaging test to assert for no message re-executions. With the new ShouldTransmit checks re-executions should never happen.

Requires

smartcontractkit/chainlink-ccip#614

Supports

smartcontractkit/chainlink-ccip#614

Update the messaging test to assert for no
message re-executions. With the new ShouldTransmit
checks re-executions should never happen.
Copy link
Contributor

github-actions bot commented Feb 14, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@makramkd makramkd changed the title integration-tests/smoke/ccip: update msging test [CCIP-5235] integration-tests/smoke/ccip: update msging test Feb 14, 2025
@makramkd makramkd marked this pull request as ready for review February 18, 2025 10:11
@makramkd makramkd requested review from a team as code owners February 18, 2025 10:11
dimkouv
dimkouv previously approved these changes Feb 18, 2025
asoliman92
asoliman92 previously approved these changes Feb 18, 2025
@makramkd makramkd enabled auto-merge February 18, 2025 11:10
@makramkd makramkd dismissed stale reviews from asoliman92 and dimkouv via 26fae28 February 18, 2025 11:25
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@makramkd makramkd added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit 2afa230 Feb 18, 2025
184 of 185 checks passed
@makramkd makramkd deleted the mk/CCIP-5235 branch February 18, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants